Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't deduplicate sort that has slice pushdown #15784

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: Don't deduplicate sort that has slice pushdown #15784

merged 1 commit into from
Apr 19, 2024

Conversation

ritchie46
Copy link
Member

fixes #15779

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 19, 2024
@ritchie46 ritchie46 merged commit 4a870cc into main Apr 19, 2024
24 checks passed
@ritchie46 ritchie46 deleted the sort branch April 19, 2024 15:33
@lorentzenchr
Copy link
Contributor

That was super fast, thanks!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 19, 2024

CodSpeed Performance Report

Merging #15784 will improve performances by 13.01%

Comparing sort (57f6456) with main (711389d)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark main sort Change
⚡ test_sort_nan_1942 1.2 ms 1 ms +13.01%

@lorentzenchr lorentzenchr mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: LazyFrame neglects head(0) if a sort follows
2 participants
@ritchie46 @lorentzenchr