Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Remove incorrect "1i (1 index count)" from some docs methods #15750

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

There are places where "1i" is allowed in the duration string language, but not always. .dt.offset_by('3i') for example doesn't make sense, because the operation can only be called on a temporal column anyway
join_asof already raises if '1i' is passed, I think the docs were just copy-and-pasted over

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Apr 18, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 18, 2024 17:43
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (96e1f01) to head (e2b40b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15750      +/-   ##
==========================================
- Coverage   81.35%   81.35%   -0.01%     
==========================================
  Files        1379     1379              
  Lines      176603   176603              
  Branches     2544     2544              
==========================================
- Hits       143677   143673       -4     
- Misses      32443    32447       +4     
  Partials      483      483              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stinodego stinodego changed the title docs(python): remove incorrect "1i (1 index count)" from some docs methods docs(python): Remove incorrect "1i (1 index count)" from some docs methods Apr 19, 2024
@stinodego stinodego merged commit 27e69b5 into pola-rs:main Apr 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants