Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure hashing with total ord is not done on references #14763

Closed
wants to merge 1 commit into from
Closed

fix: Ensure hashing with total ord is not done on references #14763

wants to merge 1 commit into from

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Feb 29, 2024 •
edited
Loading

@ritchie46 Found a spot so far, am still looking through

See tkaitchuck/aHash#214

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 29, 2024
@nameexhaustion
Copy link
Collaborator Author

nameexhaustion commented Feb 29, 2024 •
edited
Loading

Nevermind - it looks like this needs to be hashing the ref for now, the original code before any total ord stuff was also hashing the ref - which essentially hashes without ahash's specialization.

Between &T and T, it is fine as long as we are consistently using the hash of only one of them within a particular area for now.

@nameexhaustion nameexhaustion deleted the hash branch February 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 will be requested when the pull request is marked ready for review ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp will be requested when the pull request is marked ready for review orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters will be requested when the pull request is marked ready for review c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nameexhaustion