docs(python): Fix some links, and make map_batches warning more evident
#13081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
MarcoGorelli
force-pushed
the
docs-links
branch
from
44a2793 to
0e37e86
Compare
MarcoGorelli
commented
Dec 16, 2023
Comment on lines
+3987
to
+3991
| .. warning:: | ||
| If you are looking to map a function over a window function or group_by | ||
| context, refer to :func:`map_elements` instead. | ||
| Read more in `the book | ||
| <https://pola-rs.github.io/polars/user-guide/expressions/user-defined-functions>`_. |
There was a problem hiding this comment.
I don't think this note is visibible enough, so I'm suggesting to move it to a warnings directive
| alias | ||
| Expr.alias |
There was a problem hiding this comment.
this currently doesn't render, as it's from a different class (here we're in the .name namespace)
MarcoGorelli
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
stinodego
approved these changes
Dec 16, 2023
stinodego
changed the title
map_batches warning more evident
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.