Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow non-aggregation predicate in ternary groupby #12286

Merged
merged 1 commit into from
Nov 7, 2023
Merged

feat: allow non-aggregation predicate in ternary groupby #12286

merged 1 commit into from
Nov 7, 2023

Conversation

ritchie46
Copy link
Member

Was flagged as experimental. Behavior remains the same, but we don't throw a warning anymore.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 7, 2023
@stinodego
Copy link
Contributor

stinodego commented Nov 7, 2023 •
edited
Loading

There have been some issues on this in the past 🤔

Probably closes:

@ritchie46 ritchie46 merged commit 817dcae into main Nov 7, 2023
25 checks passed
@ritchie46 ritchie46 deleted the ternary branch November 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-beedie alexander-beedie alexander-beedie approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ritchie46 @stinodego @alexander-beedie