Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rustc and fix future #11696

Merged
merged 3 commits into from
Oct 12, 2023
Merged

chore: update rustc and fix future #11696

merged 3 commits into from
Oct 12, 2023

Conversation

ritchie46
Copy link
Member

fixes #11675

@ritchie46 ritchie46 requested a review from orlp as a code owner October 12, 2023 14:39
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 12, 2023
@ritchie46 ritchie46 merged commit d12dadb into main Oct 12, 2023
24 checks passed
@ritchie46 ritchie46 deleted the send branch October 12, 2023 15:47
@allinux
Copy link

allinux commented Oct 13, 2023

A build error still occurs in the stable version, 1.73, but the beta(1.74) version and nightly(1.75) version are built.
Compiler bug...?

   Compiling polars-lazy v0.33.2 (https://github.com/pola-rs/polars.git?rev=d12dadbc06efb02111deb82664287429ac23ed11#d12dadbc)
error: higher-ranked lifetime error
  --> /home/govadm/.cargo/git/checkouts/polars-b0d90607192fd414/d12dadb/crates/polars-lazy/src/physical_plan/executors/scan/parquet.rs:71:17
   |
71 | /                 polars_io::pl_async::get_runtime().block_on_potential_spawn(async {
72 | |                     let reader = ParquetAsyncReader::from_uri(
73 | |                         &self.path.to_string_lossy(),
74 | |                         self.cloud_options.as_ref(),
...  |
85 | |                     reader.finish(predicate).await
86 | |                 })
   | |__________________^
   |
   = note: could not prove `[async block@/home/govadm/.cargo/git/checkouts/polars-b0d90607192fd414/d12dadb/crates/polars-lazy/src/physical_plan/executors/scan/parquet.rs:71:77: 86:18]: Send`

@ritchie46
Copy link
Member Author

Hmm.. I think so. More info here: rust-lang/rust#102211 (comment)

But the fact that it does compile in beta is promising right? That should land in a few weeks?

romanovacca pushed a commit to romanovacca/polars that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build error when with cloud feature.
3 participants