fix!: remove fixed_seed and add pl.set_random_seed #10388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlp
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
github-actions
bot
added
breaking python
ritchie46
approved these changes
Aug 9, 2023
orlp
force-pushed
the
no-fixed-random-seed
branch
from
8d93315 to
ea16d7f
Compare
|
Does this mean that hashes will always be deterministic now, and not depend on architecture or version? Reference: #7758 (comment) Does this also effectively allow for a global seed? Then might it close #3076? |
|
This does indeed close #3076. It doesn't change anything about the hashing at the moment. |
stinodego
changed the title
stinodego
removed
breaking rust
|
@orlp can you rebase and merge this one? |
orlp
force-pushed
the
no-fixed-random-seed
branch
from
ea16d7f to
5e34cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10367.
This is a partial revert of #9694. We removed the
fixed_seedparameter. Callingshuffle(seed=n)should always do the same thing, instead, in the future we should supportshuffle(seed=expr)that allows you to set the seed per groupby if you wish to have deterministic but different seeds per group.This also adds a new function
pl.set_random_seedthat you can use to make the internal Polars RNG deterministic, instead of relying on Python'srandom.seed. Note that you might still get non-deterministic results in queries due to threading order.