Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Fix make pre-commit command #10205

Merged
merged 2 commits into from
Aug 2, 2023
Merged

chore(rust): Fix make pre-commit command #10205

merged 2 commits into from
Aug 2, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 31, 2023

Partially addresses #10199

Consider this a quick fix while I research a better way to do this...

Changes:

  • Add build.rs and related build-dependency to each crate with a nightly feature.

Seems like there isn't a nice way to have a generic build.rs for your Cargo workspace. Relevant Cargo issue:
rust-lang/cargo#8732

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jul 31, 2023
@ritchie46 ritchie46 merged commit 22a501d into main Aug 2, 2023
25 checks passed
@ritchie46 ritchie46 deleted the fix-make-precommit branch August 2, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants