Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve decimal_comma error message #18268

Closed
markxwang opened this issue Aug 19, 2024 · 0 comments · Fixed by #18269
Closed

Improve decimal_comma error message #18268

markxwang opened this issue Aug 19, 2024 · 0 comments · Fixed by #18269
Labels
documentation Improvements or additions to documentation

Comments

@markxwang
Copy link
Contributor

markxwang commented Aug 19, 2024 •
edited
Loading

Description

using pl.read_csv with decimal_comma=True will give this misleading error message:

"'decimal_comma' argument cannot be combined with ',' quote char"

It has nothing to do with the quote_char parameter, but rather the separator.

polars/crates/polars-io/src/csv/read/schema_inference.rs

Line 505 in c88da1f

polars_ensure!(b',' != separator, InvalidOperation: "'decimal_comma' argument cannot be combined with ',' quote char")

Link

No response
@markxwang markxwang added the documentation Improvements or additions to documentation label Aug 19, 2024
@markxwang markxwang changed the title Improve check_decimal_float error message Improve decimal_comma error message Aug 19, 2024
markxwang added a commit to markxwang/polars that referenced this issue Aug 19, 2024
@markxwang
pola-rs#18268 docs: improve decimal_comma error message
34a35a9
@markxwang markxwang mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Improve decimal_comma error message markxwang/polars
1 participant
@markxwang