feat: Remove outdated join validation checks

pola-rs · Apr 16, 2024 · c0833e9 · c0833e9
1 parent 1868c6d
commit c0833e9
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/crates/polars-ops/src/frame/join/args.rs b/crates/polars-ops/src/frame/join/args.rs
@@ -149,11 +149,10 @@ impl JoinValidation {
         }
     }
 
-    pub fn is_valid_join(&self, join_type: &JoinType, n_keys: usize) -> PolarsResult<()> {
+    pub(super) fn is_valid_join(&self, join_type: &JoinType) -> PolarsResult<()> {
         if !self.needs_checks() {
             return Ok(());
         }
-        polars_ensure!(n_keys == 1, ComputeError: "{self} validation on a {join_type} is not yet supported for multiple keys");
         polars_ensure!(matches!(join_type, JoinType::Inner | JoinType::Outer{..} | JoinType::Left),
                       ComputeError: "{self} validation on a {join_type} join is not supported");
         Ok(())

diff --git a/crates/polars-ops/src/frame/join/mod.rs b/crates/polars-ops/src/frame/join/mod.rs
@@ -115,8 +115,7 @@ pub trait DataFrameJoinOps: IntoDf {
         _verbose: bool,
     ) -> PolarsResult<DataFrame> {
         let left_df = self.to_df();
-        args.validation
-            .is_valid_join(&args.how, selected_left.len())?;
+        args.validation.is_valid_join(&args.how)?;
 
         #[cfg(feature = "cross_join")]
         if let JoinType::Cross = args.how {

diff --git a/py-polars/polars/dataframe/frame.py b/py-polars/polars/dataframe/frame.py
@@ -5872,7 +5872,6 @@ def join(
             .. note::
 
                 - This is currently not supported the streaming engine.
-                - This is only supported when joined by single columns.
         join_nulls
             Join on null values. By default null values will never produce matches.
 

diff --git a/py-polars/polars/lazyframe/frame.py b/py-polars/polars/lazyframe/frame.py
@@ -3762,7 +3762,6 @@ def join(
             .. note::
 
                 - This is currently not supported the streaming engine.
-                - This is only supported when joined by single columns.
         join_nulls
             Join on null values. By default null values will never produce matches.
         allow_parallel