Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transpose with option columnNames working with arrays #195

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix transpose with option columnNames working with arrays #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a0c40
Fix slice for columnNames in transpose
gustaferiksson Apr 6, 2024
807fe49
Add return type for transpose
gustaferiksson Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions __tests__/dataframe.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,6 +1104,22 @@ describe("dataframe", () => {
const actual = df.transpose({ includeHeader: false, columnNames: "abc" });
expect(actual).toFrameEqual(expected);
});
test("transpose:columnNames:array", () => {
const expected = pl.DataFrame({
a: [1, 1],
b: [2, 2],
c: [3, 3],
});
const df = pl.DataFrame({
a: [1, 2, 3],
b: [1, 2, 3],
});
const actual = df.transpose({
includeHeader: false,
columnNames: ["a", "b", "c"],
});
expect(actual).toFrameEqual(expected);
});
test("transpose:columnNames:generator", () => {
const expected = pl.DataFrame({
col_0: [1, 1],
Expand Down
6 changes: 3 additions & 3 deletions polars/dataframe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1594,7 +1594,7 @@ export interface DataFrame
includeHeader?: boolean;
headerName?: string;
columnNames?: Iterable<string>;
});
}): DataFrame;
/**
* Drop duplicate rows from this DataFrame.
* Note that this fails if there is a column of type `List` in the DataFrame.
Expand Down Expand Up @@ -2521,7 +2521,7 @@ export const _DataFrame = (_df: any): DataFrame => {
const headeName = options?.headerName ?? "column";
const keep_names_as = includeHeader ? headeName : undefined;
if (options?.columnNames) {
function takeNItems(iterable: Iterable<string>, n) {
function takeNItems(iterable: Iterable<string>, n: number) {
const result: Array<string> = [];
let i = 0;
for (const item of iterable) {
Expand All @@ -2534,7 +2534,7 @@ export const _DataFrame = (_df: any): DataFrame => {
return result;
}
options.columnNames = Array.isArray(options.columnNames)
? options.columnNames.slice(this.height)
? options.columnNames.slice(0, this.height)
: takeNItems(options.columnNames, this.height);
}
if (!options?.columnNames) {
Expand Down