-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.8.3 #137
release: 0.8.3 #137
Conversation
@Brooooooklyn were the napi images recently updated? I'm getting some unexpected failures https://github.com/pola-rs/nodejs-polars/actions/runs/6631860470/job/18016302921?pr=137 |
The error says: |
We just use what's available on the runners. Which there should be there haven't been any changes to anything android related since sept 6 (0.8.2 release). https://github.com/actions/runner-images/commits/75c3a75a803901854368855f72f414ca11bce0db/images Additionally, our CI file hasn't changed since last release, which worked fine with the same scripts. https://github.com/pola-rs/nodejs-polars/actions/runs/6104194999/job/16565845640 |
looks like it was actually bumped from 25 -> 26. |
@universalmind303 Did you see my note concerning npm/*/packages.json? They all have 0.7.2 version. Do we care? Thx |
It looks like we need to lock Bun to 1.0. GA installs Bun 1.0.7 which breaks |
@universalmind303 you can fix android build like this: Brooooooklyn/canvas@dcd7768 |
going to go ahead & merge this in as is (since the release is technically deployed I will try to work on fixing bun ci. @Bidek56 WRT npm/*/packages.json. Those are part of the deployment. No need to touch them as they auto update when running the release. |
No description provided.