Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.8.3 #137

Merged
merged 2 commits into from
Oct 26, 2023
Merged

release: 0.8.3 #137

merged 2 commits into from
Oct 26, 2023

Conversation

universalmind303
Copy link
Collaborator

No description provided.

@universalmind303
Copy link
Collaborator Author

@Brooooooklyn were the napi images recently updated? I'm getting some unexpected failures

https://github.com/pola-rs/nodejs-polars/actions/runs/6631860470/job/18016302921?pr=137

@Bidek56
Copy link
Collaborator

Bidek56 commented Oct 24, 2023

The error says: clang': No such file or directory this looks like a CI issue. Are we using old android/sdk?

@universalmind303
Copy link
Collaborator Author

universalmind303 commented Oct 24, 2023

The error says: clang': No such file or directory this looks like a CI issue. Are we using old android/sdk?

We just use what's available on the runners.

https://github.com/actions/runner-images/blob/75c3a75a803901854368855f72f414ca11bce0db/images/linux/Ubuntu2204-Readme.md

Which there should be ANDROID_NDK_LATEST_HOME available. So i don't think it's an issue with the runners.

there haven't been any changes to anything android related since sept 6 (0.8.2 release). https://github.com/actions/runner-images/commits/75c3a75a803901854368855f72f414ca11bce0db/images

Additionally, our CI file hasn't changed since last release, which worked fine with the same scripts.

https://github.com/pola-rs/nodejs-polars/actions/runs/6104194999/job/16565845640

@universalmind303
Copy link
Collaborator Author

looks like it was actually bumped from 25 -> 26.

actions/runner-images@a4234d4

@Bidek56
Copy link
Collaborator

Bidek56 commented Oct 25, 2023

@universalmind303 Did you see my note concerning npm/*/packages.json? They all have 0.7.2 version. Do we care? Thx

@Bidek56
Copy link
Collaborator

Bidek56 commented Oct 25, 2023

It looks like we need to lock Bun to 1.0. GA installs Bun 1.0.7 which breaks ts:lint

@Brooooooklyn
Copy link
Contributor

@universalmind303 you can fix android build like this: Brooooooklyn/canvas@dcd7768

@universalmind303
Copy link
Collaborator Author

going to go ahead & merge this in as is (since the release is technically deployed

I will try to work on fixing bun ci.

@Bidek56 WRT npm/*/packages.json. Those are part of the deployment. No need to touch them as they auto update when running the release.

@universalmind303 universalmind303 merged commit 453a64a into main Oct 26, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants