Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Application] Add missing (un)staking events #867

Merged
merged 195 commits into from
Oct 21, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Oct 8, 2024

Summary

Adds:

  • EventApplicationStake
  • EventApplicationUnbondingBegin
  • EventApplicationUnbondingEnd
  • EventApplicationUnbondingCanceled

Also refactors application min. stake unbonding to re-use existing unbonding period and end-blocker mechanics instead of unbonding immediately.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

tests/integration/application/min_stake_test.go Outdated Show resolved Hide resolved
tests/integration/application/min_stake_test.go Outdated Show resolved Hide resolved
x/shared/types/session.go Outdated Show resolved Hide resolved
x/shared/types/session.go Outdated Show resolved Hide resolved
@bryanchriswhite

This comment was marked as outdated.

@bryanchriswhite bryanchriswhite added push-image CI related - pushes images to ghcr.io devnet-test-e2e and removed push-image CI related - pushes images to ghcr.io devnet devnet-test-e2e labels Oct 21, 2024
Copy link

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 867)
Grafana network dashboard for devnet-issue-867

@bryanchriswhite bryanchriswhite merged commit c4d8449 into main Oct 21, 2024
10 checks passed
@bryanchriswhite bryanchriswhite deleted the issues/858/events/application branch October 21, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Changes related to the Application actor code health Cleans up some code devnet devnet-test-e2e on-chain On-chain business logic push-image CI related - pushes images to ghcr.io
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Events] Add missing events
3 participants