[Observability] Foundation for load testing telemetry #832
Conversation
okdas
changed the title
okdas
changed the title
|
Current dashboard: Unfortunately, unable to make more requests without breaking the network. |
What breaks the network? |
Same issue - #841 |
telemetry/tokens.go
Outdated
| return | ||
| } | ||
|
|
||
| // CosmosSDK has a metric called `minted_tokens` (as a part of `mint` module), however it is wrongfully marked a `gauge`. |
There was a problem hiding this comment.
Going to open a cosmos-sdk pr to address this
There was a problem hiding this comment.
@okdas Send the link and #PUC once you have it.
I'll help push it through (for review et al) on their end.
I just want to understand this last point. Informal Systems: CometBFT maintainers Why do you think they didn't have a need for the on-chain data you listed? |
I'm saying I don't think they need an exporter that exposes on-chain data. There are multiples provided by the community. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 12819930 | Triggered | Generic Password | d966241 | localnet/kubernetes/values-pocketdex-postgres.yaml | View secret |
| 12819930 | Triggered | Generic Password | ce77cc7 | localnet/kubernetes/observability-prometheus-stack.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
cmd/poktrolld/cmd/config.go
Outdated
| ) | ||
|
|
||
| var once sync.Once | ||
|
|
||
| // PoktrollAdditionalConfig represents a poktroll-specific part of `app.toml` file. | ||
| // See the `customAppConfigTemplate()` for additional information about each setting. | ||
| type PoktrollAdditionalConfig struct { |
There was a problem hiding this comment.
I looked in Cosmos & Comet and the names for these are usually RPCConfig, CustomAppConfig, serverconfig.Config, etc...
Wdyt of PoktrollAppConfig?
Additional feels weird...
Olshansk
changed the title
Co-authored-by: Daniel Olshansky <[email protected]>
|
@Olshansk ready for another pass! |
| // finalizeTelemetry logs telemetry metrics for a claim based on its stage (e.g., EXPIRED, SETTLED). | ||
| // Meant to run deferred. | ||
| func (k Keeper) finalizeTelemetry( | ||
| proofStage prooftypes.ClaimProofStage, |
| // MetricNameKeys constructs the full metric name by prefixing with a defined | ||
| // prefix and appending any additional metrics provided as variadic arguments. | ||
| // MetricNameKeys prefixes metrics with `poktroll` for easy identification. | ||
| // E.g., `("hodlers", "regret_level")` yields `poktroll_hodlers_regret_level` — great for tracking FOMO as hodlers rethink choices. |
|
e2e tests passed locally. Merging this in. |
Summary
Refactor the foundation for E2E tokenomics observability w/ lots of new data points.
Key changes include:
x/tokenomicstelemetrypoktrolltelemetry config inapp.tomlIssue