-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gateway] chore: add MsgUpdateParam
to gateway module
#808
Merged
bryanchriswhite
merged 8 commits into
main
from
issues/612/chore/gateway-msg-update-param
Sep 30, 2024
Merged
[Gateway] chore: add MsgUpdateParam
to gateway module
#808
bryanchriswhite
merged 8 commits into
main
from
issues/612/chore/gateway-msg-update-param
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
gateway
Changes related to the Gateway actor
governance
Governance related changes
on-chain
On-chain business logic
labels
Sep 10, 2024
10 tasks
15 tasks
bryanchriswhite
changed the base branch from
main
to
issues/799/tests/params
September 23, 2024 15:40
bryanchriswhite
force-pushed
the
issues/612/chore/gateway-msg-update-param
branch
2 times, most recently
from
September 23, 2024 19:36
59b9b2d
to
ae16cf3
Compare
bryanchriswhite
changed the base branch from
issues/799/tests/params
to
main
September 26, 2024 06:58
bryanchriswhite
force-pushed
the
issues/612/chore/gateway-msg-update-param
branch
from
September 26, 2024 06:59
ae16cf3
to
f7a6e5b
Compare
bryanchriswhite
added
the
consensus-breaking
IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade.
label
Sep 26, 2024
10 tasks
red-0ne
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small NIT, otherwise LGTM.
Co-authored-by: Redouane Lakrache <[email protected]>
bryanchriswhite
added a commit
that referenced
this pull request
Sep 30, 2024
…ake-gateway * pokt/main: [Gateway] chore: add `MsgUpdateParam` to gateway module (#808)
bryanchriswhite
deleted the
issues/612/chore/gateway-msg-update-param
branch
September 30, 2024 10:56
bryanchriswhite
added a commit
that referenced
this pull request
Sep 30, 2024
…ansfer-period * pokt/main: [Gateway] chore: add `MsgUpdateParam` to gateway module (#808)
Olshansk
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the necessary details in the PR description!
bryanchriswhite
added a commit
that referenced
this pull request
Oct 4, 2024
## Summary Adds the `min_stake_gateway` param to the gateway. ## Depends on - #808 - #827 - #826 ## Issue - #612 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [x] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Redouane Lakrache <[email protected]> Co-authored-by: red-0ne <[email protected]>
10 tasks
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary ``` ignite scaffold message update-param --module gateway --signer authority name as_type --response params ``` Adds the `MsgUpdateParam` message so that the gateway module may update individual parameters. The gateway module's `min_stake` param will be added in #809. ## Issue - #612 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [ ] I have commented my code - [ ] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Redouane Lakrache <[email protected]>
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary Adds the `min_stake_gateway` param to the gateway. ## Depends on - #808 - #827 - #826 ## Issue - #612 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [x] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Redouane Lakrache <[email protected]> Co-authored-by: red-0ne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consensus-breaking
IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade.
gateway
Changes related to the Gateway actor
governance
Governance related changes
on-chain
On-chain business logic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
MsgUpdateParam
message so that the gateway module may update individual parameters. The gateway module'smin_stake
param will be added in #809.Issue
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist