Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gateway] chore: add MsgUpdateParam to gateway module #808

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Sep 10, 2024

Summary

ignite scaffold message update-param --module gateway --signer authority name as_type --response params

Adds the MsgUpdateParam message so that the gateway module may update individual parameters. The gateway module's min_stake param will be added in #809.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added gateway Changes related to the Gateway actor governance Governance related changes on-chain On-chain business logic labels Sep 10, 2024
@bryanchriswhite bryanchriswhite self-assigned this Sep 10, 2024
@bryanchriswhite bryanchriswhite linked an issue Sep 10, 2024 that may be closed by this pull request
10 tasks
@bryanchriswhite bryanchriswhite changed the base branch from main to issues/799/tests/params September 23, 2024 15:40
@bryanchriswhite bryanchriswhite force-pushed the issues/612/chore/gateway-msg-update-param branch 2 times, most recently from 59b9b2d to ae16cf3 Compare September 23, 2024 19:36
@bryanchriswhite bryanchriswhite changed the base branch from issues/799/tests/params to main September 26, 2024 06:58
@bryanchriswhite bryanchriswhite force-pushed the issues/612/chore/gateway-msg-update-param branch from ae16cf3 to f7a6e5b Compare September 26, 2024 06:59
@bryanchriswhite bryanchriswhite marked this pull request as ready for review September 26, 2024 09:05
@bryanchriswhite bryanchriswhite added the consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. label Sep 26, 2024
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small NIT, otherwise LGTM.

x/gateway/keeper/msg_server_update_param.go Show resolved Hide resolved
@bryanchriswhite bryanchriswhite merged commit 1223502 into main Sep 30, 2024
10 checks passed
bryanchriswhite added a commit that referenced this pull request Sep 30, 2024
…ake-gateway

* pokt/main:
  [Gateway] chore: add `MsgUpdateParam` to gateway module (#808)
@bryanchriswhite bryanchriswhite deleted the issues/612/chore/gateway-msg-update-param branch September 30, 2024 10:56
bryanchriswhite added a commit that referenced this pull request Sep 30, 2024
…ansfer-period

* pokt/main:
  [Gateway] chore: add `MsgUpdateParam` to gateway module (#808)
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the necessary details in the PR description!

bryanchriswhite added a commit that referenced this pull request Oct 4, 2024
## Summary

Adds the `min_stake_gateway` param to the gateway.

## Depends on

- #808 
- #827
- #826

## Issue

- #612

## Type of change

Select one or more from the following:

- [x] New feature, functionality or library
- [x] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [x] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [ ] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [x] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable

---------

Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: red-0ne <[email protected]>
okdas pushed a commit that referenced this pull request Nov 14, 2024
## Summary

```
ignite scaffold message update-param --module gateway --signer authority name as_type --response params
```

Adds the `MsgUpdateParam` message so that the gateway module may update
individual parameters. The gateway module's `min_stake` param will be
added in #809.

## Issue

- #612 

## Type of change

Select one or more from the following:

- [x] New feature, functionality or library
- [x] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [ ] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [ ] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [ ] I have tested my changes using the available tooling
- [ ] I have commented my code
- [ ] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable

---------

Co-authored-by: Redouane Lakrache <[email protected]>
okdas pushed a commit that referenced this pull request Nov 14, 2024
## Summary

Adds the `min_stake_gateway` param to the gateway.

## Depends on

- #808 
- #827
- #826

## Issue

- #612

## Type of change

Select one or more from the following:

- [x] New feature, functionality or library
- [x] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [x] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [ ] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [x] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable

---------

Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: red-0ne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. gateway Changes related to the Gateway actor governance Governance related changes on-chain On-chain business logic
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants