Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RelayMiner] Fix non deleted smt when funds are insufficient to submit C&P #1026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Jan 13, 2025

Summary

This pull request includes changes to pkg/relayer/session/claim.go to

  1. Delete SMTs when funds are insufficient.
  2. Account for the gas cost of creating claims and submitting proofs.

Issue

When the SupplierOperator lacks sufficient funds to process claim and proof submissions, the corresponding SMTs are not deleted from the file system. This issue becomes more severe at scale, especially when the RelayMiner is handling multiple claims from various applications.

image

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@red-0ne red-0ne added relayminer Changes related to the Relayminer off-chain Off-chain business logic labels Jan 13, 2025
@red-0ne red-0ne added this to the Beta TestNet Iteration milestone Jan 13, 2025
@red-0ne red-0ne self-assigned this Jan 13, 2025
Tiltfile Show resolved Hide resolved
pkg/relayer/session/claim.go Outdated Show resolved Hide resolved
pkg/relayer/session/claim.go Outdated Show resolved Hide resolved
pkg/relayer/session/claim.go Outdated Show resolved Hide resolved
@red-0ne red-0ne requested a review from Olshansk January 14, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
off-chain Off-chain business logic relayminer Changes related to the Relayminer
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants