Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gnosis merge checker #1006

Merged
merged 4 commits into from
Dec 8, 2022
Merged

feat: gnosis merge checker #1006

merged 4 commits into from
Dec 8, 2022

Conversation

crisog
Copy link
Contributor

@crisog crisog commented Dec 5, 2022

Preparing the merge checker to support Gnosis Merge.

@height
Copy link

height bot commented Dec 5, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@crisog crisog marked this pull request as draft December 5, 2022 15:20
@crisog crisog marked this pull request as ready for review December 8, 2022 18:20
@crisog crisog requested a review from adshmh December 8, 2022 18:50
@crisog crisog requested review from adshmh and blockjoe December 8, 2022 19:08
blockjoe
blockjoe approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@blockjoe blockjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TDD value checks out for post merge Gnosis 👍

@crisog crisog merged commit 0da3cf9 into develop Dec 8, 2022
@crisog crisog deleted the gnosis-merge branch December 8, 2022 19:25
This was referenced Dec 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockjoe blockjoe blockjoe approved these changes

@adshmh adshmh adshmh approved these changes

@kutoft kutoft kutoft approved these changes

@rem1niscence rem1niscence Awaiting requested review from rem1niscence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisog @kutoft @adshmh @blockjoe