Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Pokemon Egg Distance #1

Open
Sifogiannos opened this issue May 7, 2018 · 7 comments
Open

Pokemon Egg Distance #1

Sifogiannos opened this issue May 7, 2018 · 7 comments
Labels
feature New feature or request help wanted Extra attention is needed open for PR

Comments

@Sifogiannos
Copy link

Could it be easy to add pokemon egg distance?

@BrunnerLivio
Copy link
Contributor

I'm actually unable to find that information in the GAME_MASTER files.

Maybe you have more luck. Search here

@BrunnerLivio BrunnerLivio added feature New feature or request help wanted Extra attention is needed labels May 7, 2018
@Sifogiannos
Copy link
Author

As i can see, in the specific file "GAME_MASTER" there is none data for pokemon egg distance, we should probably import another file that contain that data.

@BrunnerLivio
Copy link
Contributor

I don't like relying on third party services. Any suggestions though?

@Furtif
Copy link

Furtif commented May 9, 2018

Look this

@BrunnerLivio
Copy link
Contributor

Kinda forgot this issue, sorry about that.
@Furtif thanks for this snippet. I do not want to debug your code; can you elaborate how you calculate this? Like which data from the GAME_MASTER.json is needed in order to calculate the Egg Distance?

@Sifogiannos
Copy link
Author

Long time no see, i dont know if its a good idea but it just an opinion.
We could use the data form https://www.serebii.net/pokemongo/pokemon.shtml to extract data for egg hatching and then merge them with the available data from game master.

What do you think?

@BrunnerLivio
Copy link
Contributor

BrunnerLivio commented Oct 30, 2018

@Sifogiannos
Hmm serebii is quite reliable, so I guess could be doable. Do not really have the time to implement it myself though :/

@BrunnerLivio BrunnerLivio self-assigned this Oct 30, 2018
BrunnerLivio pushed a commit that referenced this issue Nov 2, 2018
@BrunnerLivio BrunnerLivio removed their assignment May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request help wanted Extra attention is needed open for PR
Projects
None yet
Development

No branches or pull requests

3 participants