Override Test ID to ensure trait dependencies are cached #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like this could also be solved with a Is there a plan for how to be backwards compatible with different versions of |
jflan-dd
commented
Oct 17, 2024
Comment on lines
+402
to
+403
| // unsafeBitCast used because current version of xctest-dynamic-overlay does not expose init | ||
| self.testIdentifier = unsafeBitCast(testID, to: TestContext.Testing.Test.ID.self) |
There was a problem hiding this comment.
This hack is the main reason I marked this PR as a draft
|
@jflan-dd Thanks for looking into this and putting together a PR! We'll try to review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where reference typed dependencies weren't correctly cached if they were updated in-place rather than being fully overridden.
The root cause of this seems to be that
Test.currentisn't set duringprepare(for test: Test)and as a result theCacheKey.testIdentifierwasnilduring dependency setup.This PR creates an internal
TestIDstruct that can be explicitly overridden during dependency prep, but perhaps there's a more elegant solution that could be implemented inxctest-dymaic-overlaydirectly.