Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer warning message #167

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

ZevEisenberg
Copy link
Contributor

Old warning message:

Do not use 'unimplemented' with '@DependencyClient'; it is a replacement and implements the same runtime functionality as 'unimplemented' at compile time

This was confusing because it was not clear what “it” referred to, nor what was a “replacement” for what.

New warning message:

Do not use 'unimplemented' with '@DependencyEndpoint'; the '@DependencyEndpoint' macro provides an 'unimplemented' default value for you.

I also added a period at the end, but I can remove it if it’s not consistent with project style.

@ZevEisenberg
Copy link
Contributor Author

Updated with workshopped message.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit a22fd06 into pointfreeco:main Jan 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants