Fix race condition in FileStorageKey #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mbrandonw
changed the title
mbrandonw
commented
Nov 12, 2024
Comment on lines
252
to
+254
| try fileStorage.save(Data(), .fileURL) | ||
| scheduler.run() | ||
| expectNoDifference(users, []) | ||
| expectNoDifference(users, [.blob]) |
There was a problem hiding this comment.
Changes made to the file on disk will be ignored if there is an enqueued state change waiting to be saved.
stephencelis
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition between mutating
@Shared(.fileStorage)directly and the file system notifying it of changes on disk.