Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/binary-accuracy #87

Merged
merged 6 commits into from
Aug 24, 2020
Merged

feature/binary-accuracy #87

merged 6 commits into from
Aug 24, 2020

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Aug 22, 2020

  • Implements elegy.metrics.BinaryAccuracy and elegy.metrics.binary_accuracy
  • Logs dont block in the output of train_on_batch and test_on_batch
  • Ports an implementation of the Transformer, TransformerDecoder and TransformerEncoder from Pytorch. These Modules are not yet part of the public API.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2020

Codecov Report

Merging #87 into master will decrease coverage by 0.15%.
The diff coverage is 9.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   70.56%   70.41%   -0.16%     
==========================================
  Files          82       84       +2     
  Lines        3781     3802      +21     
==========================================
+ Hits         2668     2677       +9     
- Misses       1113     1125      +12     
Impacted Files Coverage Δ
elegy/callbacks/callback_list.py 80.79% <ø> (+0.27%) ⬆️
elegy/model.py 63.44% <ø> (ø)
elegy/nn/multi_head_attention.py 0.00% <0.00%> (ø)
elegy/nn/transformers.py 0.00% <0.00%> (ø)
elegy/metrics/binary_accuracy.py 66.66% <66.66%> (ø)
elegy/metrics/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d9f2b...2cbe9a0. Read the comment docs.

@charlielito
Copy link
Collaborator

@cgarciae split this in 3 PRs :D

@cgarciae cgarciae merged commit 5742d16 into master Aug 24, 2020
@cgarciae cgarciae deleted the feature/binary-accuracy branch August 24, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants