Add destination "directory_name" option.
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,11 +46,15 @@ module.exports = { | |||
| } | |||
|
|
|||
| function copy() { | |||
| return runCommand('cp -R dist/* .', execOptions); | |||
| if (options.destination === '.') { | |||
| } | ||
|
|
||
| function addAndCommit() { | ||
| return runCommand('git add . && git commit -m "' + options.message + '"', execOptions) | ||
| return runCommand('git -c core.safecrlf=false add "' + options.destination + '"' + |
|
I assume the line length style issues are okay. I shortened the lines, but not at the expense of semantic clarity. I also have no idea what |
DanChadwick
changed the title
destination "directoy_name" option.destination "directory_name" option.
|
Will do testing on osx before releasing. |
|
Thanks so much for the quick response, @knownasilya! Please post back in this issue if you find anything (so I can warn my Mac-loving co-consipirators). If/when you release, I'll update |
knownasilya
pushed a commit
that referenced
this pull request
Jun 8, 2016
|
Released as v0.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at
ember-paper, we are using your excellent add-on to build two different branches into two different dummy apps. Having this destination option will make it easy for us to continue to use the workflow you created. Thanks for the consideration.Note: I had some difficulty getting this to work with both Windows and Linux. Testing on mac and linux would be awesome, as I tested only on windows. It is a touch difficult since windows runs the commands with
cmd.exe, not bash.