Fixup to e3b2201f: prevent open::that from blocking, fix a typo, minor code simplification #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
fixup
branch
3 times, most recently
from
2ac3fcb to
ebb1937
Compare
ilyagr
changed the title
ilyagr
force-pushed
the
fixup
branch
5 times, most recently
from
2b72de2 to
e0cb9d1
Compare
`open::that` can block, for example when `firefox` is the default browser on Linux and no instance of `firefox` is running.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open::thatcan block, for example whenfirefoxis the default browseron Linux and no instance of
firefoxis running.Perhaps
tokio::spawn_blockingwithopen::thatwould be better in terms of error handling than usingthat_detached. The latter does not report an error if the browser exits with an error code. OTOH, withopen::that, killing the server might kill the browser...