[PathPattern] Record and use PathPattern in response #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so metrics correctly report the innermost PathPattern. poem-web#461
kolloch
force-pushed
the
feature/fix-461-http-path-pattern
branch
from
8798abc to
05d8cf6
Compare
added 2 commits
December 21, 2022 11:42
...that tests whether the middleware sees the innermost PathPattern in the response. poem-web#461
kolloch
commented
Dec 21, 2022
| @@ -47,7 +47,7 @@ impl<E: Endpoint> Endpoint for TracingEndpoint<E> { | |||
| ); | |||
|
|
|||
| if let Some(path_pattern) = req.data::<PathPattern>() { | |||
| span.record("path_pattern", path_pattern.0.as_ref()); | |||
| span.record("path_pattern", &path_pattern.0.as_ref()); | |||
There was a problem hiding this comment.
@sunli829 This was necessary to make poem compile locally. Not sure why it passed in CI/CD in the old version.
I compiled with rust 1.65
|
This is a quality PR, thanks a lot! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so metrics correctly report the innermost PathPattern.
#461