Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the examples, listen on 0.0.0.0 instead of 127.0.0.1 #664

Closed
byte-sized-emi opened this issue Oct 1, 2023 · 5 comments
Closed

In the examples, listen on 0.0.0.0 instead of 127.0.0.1 #664

byte-sized-emi opened this issue Oct 1, 2023 · 5 comments

Comments

@byte-sized-emi
Copy link
Contributor

Listening from localhost (127.0.0.1) might work well for a development environment, but when deployed in a docker container the service will not be accessible from outside. Especially for people that know little about networking / docker in general, something like this can be very frustrating to debug - the container will be running, networking will be correctly setup, but every connection is refused.

@attila-lin
Copy link
Collaborator

Nice catch.

PR are welcome!

@byte-sized-emi
Copy link
Contributor Author

Alright, I'll make a PR - just to be sure, I didn't mention it in the original issue, listening on 0.0.0.0 means that the developer will most likely expose their poem service on the local network (in the case where it's not running in a container). Just wanted to mention that.

@attila-lin
Copy link
Collaborator

Yes, we may add some comments on 0.0.0.0 to notify the newbie.

@byte-sized-emi
Copy link
Contributor Author

Not sure if I've forgotten anything, but this should be everything in examples/ plus README's and a couple doc comments

sunli829 pushed a commit that referenced this issue Nov 18, 2023
* In the examples, listen on 0.0.0.0 instead of 127.0.0.1 #664

* Fix accidentally replaced ip's
@attila-lin
Copy link
Collaborator

seems finished.

Please reopen if anything is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants