feat: adds log page for builds #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
dgolovin,
feloy and
deboer-tim
and removed request for
a team
cdrage
force-pushed
the
add-log-screen
branch
4 times, most recently
from
803efc7 to
095f5d4
Compare
deboer-tim
requested changes
Sep 10, 2024
### What does this PR do? * Adds a log action button that will show the logs in real-time in a separate page * Automatically refreshes / appends to the output * Uses terminal settings from Podman Desktop to match what the user has setup. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#677 ### How to test this PR? 1. Start a build 2. Click the "logs" button on the dashboard 3. Watch logs propagate <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <[email protected]>
cdrage
force-pushed
the
add-log-screen
branch
from
095f5d4 to
32fc9e8
Compare
|
@deboer-tim updated!
|
deboer-tim
approved these changes
Sep 11, 2024
Signed-off-by: Charlie Drage <[email protected]>
cdrage
force-pushed
the
add-log-screen
branch
from
32fc9e8 to
b535ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: adds log page for builds
What does this PR do?
separate page
setup.
Screenshot / video of UI
Screen.Recording.2024-09-05.at.12.14.03.PM.mov
Screen.Recording.2024-09-05.at.12.16.31.PM.mov
What issues does this PR fix or reference?
Closes #677
How to test this PR?
Signed-off-by: Charlie Drage [email protected]