feat: open webview from image action #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this needed? |
|
This is removing the quick pick and making all the paths go to the webview - isn't that the intention? |
cdrage
reviewed
Mar 26, 2024
deboer-tim
force-pushed
the
form-view-only
branch
2 times, most recently
from
e413bf9
to
598675e
Compare
Removes the quick pick command, and instead triggers opening the webview, switching to the build page, and preselecting the image. Signed-off-by: Tim deBoer <[email protected]>
Adding tests for the command redirecting to the build page, and for the build page allowing an initial selection. To test a select control the values must be strings, so I had to rework the Build page a bit to use string values. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
force-pushed
the
form-view-only
branch
from
53603cd
to
142f18e
Compare
|
Added tests, and rebased on main. Ready for full review. |
cdrage
requested changes
Mar 28, 2024
|
|
||
| // if we trigger immediately, the webview hasn't loaded yet and can't redirect | ||
| // if we trigger too slow, there's a visible flash as the homepage appears first | ||
| await new Promise(r => setTimeout(r, 100)); |
There was a problem hiding this comment.
Signed-off-by: Tim deBoer <[email protected]>
cdrage
approved these changes
Mar 28, 2024
cbr7
pushed a commit
to cbr7/podman-desktop-extension-bootc
that referenced
this pull request
Apr 11, 2024
* feat: open webview from image action Removes the quick pick command, and instead triggers opening the webview, switching to the build page, and preselecting the image. Signed-off-by: Tim deBoer <[email protected]> * chore: add tests Adding tests for the command redirecting to the build page, and for the build page allowing an initial selection. To test a select control the values must be strings, so I had to rework the Build page a bit to use string values. Signed-off-by: Tim deBoer <[email protected]> * chore: respond to review comments Signed-off-by: Tim deBoer <[email protected]> --------- Signed-off-by: Tim deBoer <[email protected]> Signed-off-by: Vladimir Lazar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the quick pick command, and instead triggers opening the webview, switching to
the build page, and preselecting the image.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
How to test this PR?
Tests still to-do.