chore: respond to review comments

Signed-off-by: Tim deBoer <[email protected]>
podman-desktop · Mar 28, 2024 · 547d229 · 547d229
1 parent 142f18e
commit 547d229
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/packages/backend/src/extension.ts b/packages/backend/src/extension.ts
@@ -93,8 +93,6 @@ export async function openBuildPage(
   panel: extensionApi.WebviewPanel,
   image: { name: string; tag: string },
 ): Promise<void> {
-  console.log('Opening webview for ' + image.name);
-
   // this should use webview reveal function in the future
   const webviews = extensionApi.window.listWebviews();
   const bootcWebView = (await webviews).find(webview => webview.viewType === 'bootc');
@@ -112,7 +110,6 @@ export async function openBuildPage(
 
   await panel.webview.postMessage({
     id: Messages.MSG_NAVIGATE_BUILD,
-    // Must pass in an empty body to satisfy the type system. If it is undefined, this fails
     body: encodeURIComponent(image.name) + '/' + encodeURIComponent(image.tag),
   });
 }

diff --git a/packages/frontend/src/App.svelte b/packages/frontend/src/App.svelte
@@ -21,7 +21,6 @@ onMount(() => {
   isMounted = true;
 
   return rpcBrowser.subscribe(Messages.MSG_NAVIGATE_BUILD, (x: string) => {
-    console.log(`Navigating to /build/${x}`);
     router.goto(`/build/${x}`);
   });
 });

diff --git a/packages/frontend/src/Build.svelte b/packages/frontend/src/Build.svelte
@@ -53,15 +53,13 @@ async function fillBuildOptions() {
   // If an image name and tag were passed in, try to use it as the initially selected image
   let initialImage: ImageInfo | undefined;
   if (imageName && imageTag) {
-    console.log('Preselecting image: ' + imageName + ' ' + imageTag);
     initialImage = findImage(`${imageName}:${imageTag}`);
   }
 
   // If not, use the last image from history if it is valid
-  if (!initialImage && historyInfo.length > 0) {
-    const latestBuild = historyInfo[0];
+  if (!initialImage && historyInfo.length > 0 && historyInfo[0].image && historyInfo[0].tag) {
     // Find the image that matches the latest build's name and tag
-    initialImage = findImage(`${latestBuild.image}:${latestBuild.tag}`);
+    initialImage = findImage(`${historyInfo[0].image}:${historyInfo[0].tag}`);
   }
 
   if (initialImage && initialImage.RepoTags && initialImage.RepoTags.length > 0) {