Integrate form library #28
Conversation
There was a problem hiding this comment.
@uzuntonev Awesome work, thanks for the integration! 💯
We had some hesitations on which form library should be chosen.
I guess Formik is good choice at this point and will help us move faster in the future.
In the next updates I'll be happy to see integration of types/interfaces with the form library as this will ensure our form payloads are strongly typed.
| const ChangePasswordSchema = yup.object().shape({ | ||
| password: yup | ||
| .string() | ||
| .min(6, t('auth:validation.password-min', { count: 6 })) |
There was a problem hiding this comment.
It's gonna be better to handle the translation at the last step right before displaying the error.
Otherwise we risk to receive mixed translations as the messages are memoized.
We can handle similar validations in a central location as it's shown at https://github.com/jquense/yup#using-a-custom-locale-dictionary
This will also help us decompose the validation schema definition in a separate file, away from the actual form component implementation.
Not super important at this stage but in future can be confusing.
Peek.2021-02-06.12-05.mp4
Motivation and context
Screenshots:
New dependencies:
formikyupNew dev dependencies:
@types/yup