-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Donation flow more fixes #1989
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0f89470
chore: Fix inline registration
sashko9807 882ffb4
fix: Add minimum width to svgs for donation payment
sashko9807 668c99a
chore: Add full stop at the end of the sentence
sashko9807 362c972
fix: Social links buttons not working
sashko9807 9a0d48b
chore: Make amountChosen optional for now
sashko9807 a0fe287
fix: Typo in translation key
sashko9807 5425fed
chore: Remove redundant log
sashko9807 2310683
chore: Remove redundant log
sashko9807 e926ba1
chore: Remove redundant logs
sashko9807 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ import { | |
PopoverProps, | ||
ButtonProps, | ||
} from '@mui/material' | ||
import { ContentCopy, Facebook, LinkedIn, Share, Twitter } from '@mui/icons-material' | ||
import { ContentCopy, Facebook, LinkedIn, Share, Twitter, X } from '@mui/icons-material' | ||
|
||
import { AlertStore } from 'stores/AlertStore' | ||
import theme from 'common/theme' | ||
|
@@ -25,8 +25,9 @@ export default function SocialShareListButton({ | |
}) { | ||
const { t } = useTranslation('common') | ||
const [anchorEl, setAnchorEl] = React.useState<HTMLButtonElement | null>(null) | ||
const serializedUrl = new URLSearchParams(url).toString() | ||
|
||
const handleClick = (event: React.MouseEvent<HTMLButtonElement>) => { | ||
console.log(event.currentTarget) | ||
setAnchorEl(event.currentTarget) | ||
} | ||
|
||
|
@@ -56,26 +57,27 @@ export default function SocialShareListButton({ | |
<ListItemButton | ||
onClick={() => { | ||
navigator.clipboard.writeText(url) | ||
console.log(url) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. console log again - ditto |
||
AlertStore.show('Campaign link copied to clipboard', 'success') | ||
setAnchorEl(null) | ||
}}> | ||
<Typography>{t('components.social-share.copy')}</Typography> | ||
<ContentCopy sx={{ ml: 1, fill: theme.palette.grey[400] }} /> | ||
</ListItemButton> | ||
<ListItemButton href={`https://www.facebook.com/sharer/sharer.php?u=${serializedUrl}`}> | ||
<ListItemButton href={`https://www.facebook.com/sharer/sharer.php?u=${url}`}> | ||
<Typography>{t('components.social-share.share')} Facebook</Typography> | ||
<Facebook sx={{ ml: 1, fill: '#4267B2' }} /> | ||
</ListItemButton> | ||
<ListItemButton | ||
href={` | ||
http://www.linkedin.com/shareArticle?mini=true&url=${serializedUrl} | ||
http://www.linkedin.com/shareArticle?mini=true&url=${url} | ||
`}> | ||
<Typography>{t('components.social-share.share')} LinkedIn</Typography> | ||
<LinkedIn sx={{ ml: 1, fill: '#0077b5' }} /> | ||
</ListItemButton> | ||
<ListItemButton href={`https://twitter.com/intent/tweet?url=${serializedUrl}`}> | ||
<Typography>{t('components.social-share.share')} Twitter</Typography> | ||
<Twitter sx={{ ml: 1, fill: '#1DA1F2' }} /> | ||
<ListItemButton href={`https://x.com/intent/post?url=${url}`}> | ||
<Typography>{t('components.social-share.share')} X</Typography> | ||
<X sx={{ ml: 1 }} /> | ||
</ListItemButton> | ||
</List> | ||
</Popover> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably dont need that one