Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New campaign statuses #1956

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sashko9807
Copy link
Member

Add new statuses for campaign
Partially Closes #1881

Copy link

github-actions bot commented Oct 9, 2024

❌ Not all tests have run for this PR. Please add the run tests label to trigger them.

{t('cta.support')}
</DonateButton>
)}
{campaignState === CampaignState.active ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be I don't understand...
Isn't this going to hide the donation button for ACTIVE campaigns?

campaignState === CampaignState.active - this will be TRUE so the rest won't be evaluated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@sashko9807 sashko9807 requested a review from slavcho December 6, 2024 23:49
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Dec 6, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New status for completed campaigns
3 participants