-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Campaign Applications (alpha) #1930
Merged
sashko9807
merged 10 commits into
podkrepi-bg:master
from
gparlakov:admin-list-campaign-appications-actual
Sep 25, 2024
Merged
Campaign Applications (alpha) #1930
sashko9807
merged 10 commits into
podkrepi-bg:master
from
gparlakov:admin-list-campaign-appications-actual
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Tests will run for this PR. Once they succeed it can be merged. |
- handle file upload one by one to allow for handling errors individually (otherwise the server just returns response failed for any one file that fails and no information about the successful uploads) - add summary where the uploaded and failed (if any) files are top and center - add a short explanation of what to do about failed files
- send campaignTypeId instead of the category (which is a property of the campaign type and is not enough to uniquely distinguish the type) - allow for editing and re-editing - style the summary - fix linting errors
- moved the useCreateOrEditApplication hook to own file to reuse for the admin campaign edit - added campaign end date handling (if the user selects a date for the end it pops up an input and fills in the preselected by user date or today if none) - removed some unused props from the cam app details - added msw v1 https://v1.mswjs.io/docs/getting-started/mocks/rest-api to mock the server responses for testing (Mock Service Worker) - expanded the test setup to provide Session and QueryClient
- it uses the same controls/steps as the organizer edit but adds the admin only props on top - adds a link and copy button for the link where organizer can edit so as to include it if sending a mail to the org (e.g. for more info) - deletes the admin types - using same as regular - adds the status dropdown for admin edit - allows the accept terms checkboxes to be disabled for admin
gparlakov
force-pushed
the
admin-list-campaign-appications-actual
branch
from
September 21, 2024 04:21
6fd5644
to
14cb2cc
Compare
sashko9807
added
the
run tests
Allows running the tests workflows for forked repos
label
Sep 24, 2024
github-actions
bot
removed
the
run tests
Allows running the tests workflows for forked repos
label
Sep 24, 2024
sashko9807
approved these changes
Sep 24, 2024
ani-kalpachka
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing and file upload and admin section for campaign applications - finalizes first alpha version of the whole process
feat: file upload and summary
send campaignTypeId instead of the category (which is a property of the campaign type and is not enough to uniquely distinguish the type)
chore: test create application
chore: add tests for the createOrEdit application hook
feat: admin edit
feat: actual list of campaign applications
#1842
Screenshots:
Testing
Steps to test
Affected urls
/campaigns/application
/campaigns/application/eb4347a2-c8b4-47f1-83e5-67457b20909c
/admin/campaign-applications
/admin/campaign-applications/edit/eb4347a2-c8b4-47f1-83e5-67457b20909c
New or updated dependencies:
msw
v1.x.x