Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign application notify successful and failed files for the camapp #1921

Conversation

gparlakov
Copy link
Contributor

feat: file upload and summary

  • handle file upload one by one to allow for handling errors individually (otherwise the server just returns response failed for any one file that fails and no information about the successful uploads)
  • add summary where the uploaded and failed (if any) files are top and center
  • add a short explanation of what to do about failed files

image

Copy link

github-actions bot commented Sep 6, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

- handle file upload one by one to allow for handling errors individually (otherwise the server just returns response failed for any one file that fails and no information about the successful uploads)
- add summary where the uploaded and failed (if any) files are top and center
- add a short  explanation of what to do about failed files
@gparlakov gparlakov force-pushed the campaign-application-notify-successful-and-failed-files-for-the-camapp branch from a2e0883 to 128d465 Compare September 13, 2024 08:32
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Sep 13, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 13, 2024
@gparlakov gparlakov closed this Sep 13, 2024
@gparlakov gparlakov deleted the campaign-application-notify-successful-and-failed-files-for-the-camapp branch September 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants