Update positive amount error message on Admin panel forms #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavcho
reviewed
Jul 22, 2024
| @@ -66,7 +66,7 @@ const validationSchema: yup.SchemaOf<CampaignAdminCreateFormData> = yup | |||
| title: yup.string().trim().min(10).max(200).required(), | |||
| slug: yup.string().trim().min(10).max(200).optional(), | |||
| description: yup.string().trim().min(50).max(60000).required(), | |||
| targetAmount: yup.number().integer().positive().required(), | |||
| targetAmount: yup.number().integer().positive('validation:positive-amount').required(), | |||
There was a problem hiding this comment.
shouldn't we use the t() function: positive(t('...'))
Or this is done somehow automatically?
There was a problem hiding this comment.
@slavcho Yes, the translation is accessible in the validationSchema const without the t() function. All of the validation messages are displayed in this way and I kept the consistency.
slavcho
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes will close #1786 and update positive amount error message on all forms in the Admin panel.