feat: prefill campaign application organizer form values from current user (Epic #1842) #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
requested changes
Jul 9, 2024
| const [activeStep, setActiveStep] = useState<Steps>(Steps.ORGANIZER) | ||
|
|
||
| const initialValues: CampaignApplicationFormData = useMemo( |
There was a problem hiding this comment.
useMemo isn't really needed for this case
We don't do any calculations here.
There was a problem hiding this comment.
Okay, removed
| import Layout from '../layout/Layout' | ||
| import CampaignApplicationForm from './CampaignApplicationForm' | ||
|
|
||
| export default function CampaignApplicationPage() { | ||
| const { data: session } = useSession() | ||
| const { data: person, isLoading } = useViewPersonByKeylockId(session?.user?.sub as string) |
There was a problem hiding this comment.
Check useCurrentPerson hook, should do the exact same job.
There was a problem hiding this comment.
Yep, done
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefill campaign application organizer form values from current user as requested in the following task https://github.com/users/gparlakov/projects/1/views/1?pane=issue&itemId=68583764
*Connected to Epic #1842
Screenshots:
Testing
Steps to test
http://localhost:3040/campaigns/application