add help us improve field to all registrations #1737
Conversation
|
❌ Not all tests have run for this PR. Please add the |
There was a problem hiding this comment.
Well done. There are minor last-minute changes to the text, mentioned below, please look at them.
This commit should also be supplemented, by changes in the backend as well, in order to keep track of who actually has agreed to help, so if you can please do.
Needed changes to the backend are:
-
Adding helpUsImprove field, to the prisma model
-
Adding helpUsImprove property, to the registerDto
If you have any further questions, regarding the requested changes feel free to contact me anytime.
Thank you for your contribution!
public/locales/bg/validation.json
Outdated
| "eik-invalid": "Невалидно ЕИК" | ||
| } | ||
| "eik-invalid": "Невалидно ЕИК", | ||
| "help-us-improve": "Искате ли да ни помогнете да подобрим платформата? Искаме да чуем вашето мнение? Отделете ни 30 мин за подобрите платформа на подкрепи.бг" |
There was a problem hiding this comment.
It was discussed with the design team, it is better to replace 30 мин with 30 минути.
Same goes for the EN translation, 30 mins to 30 minutes
There was a problem hiding this comment.
I would update it to:
"Искате ли да ни помогнете да подобрим платформата? Искаме да чуем Вашето мнение? Отделете ни 30 минути, за подобрите платформа на Подкрепи.бг""
There was a problem hiding this comment.
"Искаме да чуем вашето мнение" and "We want to hear from you" are plain statements and don't need question mark unless the original intend was to read "Искате да чуем вашето мнение?" and "You want us to hear from you?"
| label={ | ||
| <Typography variant="body2"> | ||
| {t('validation:help-us-improve')}{' '} | ||
| {/* <ExternalLink href={routes.helpUsImprove}> |
There was a problem hiding this comment.
Please remove the commented line.
sashko9807
added
the
run tests
sashko9807
added
run tests
sashko9807
added
the
run tests
Added a new tick box in Registration Forms for both EN and BG.
Before:
After:
