pages/campaigns: Optimizations and improvements #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pages/campaigns/index.tsx: Run asynchronous tasks concurrently campaigns/CampaignFilter.tsx: Remove unnecessary array.filter call, when no filter is set - No need to loop through all campaigns, if no filter is set. /campaigns/CampaignsList.tsx: Use campaign id as key, rather than array index Index is not unique value, as length of array can vary.
ImageList is not the best thing for such things. Replaced it with self-made grid
|
❌ Not all tests have run for this PR. Please add the |
sashko9807
changed the title
ani-kalpachka
approved these changes
Mar 16, 2024
|
Well done, @sashko9807 ! |
Would you clarify? I see no conflicts with the master branch being reported |
ani-kalpachka
approved these changes
Mar 17, 2024
ani-kalpachka
added
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pages/campaigns/index.tsx: Run asynchronous tasks concurrently
campaigns/CampaignFilter.tsx:
<ImageList>with Grid/campaigns/CampaignsList.tsx:
/campaigns/CampaignsPage.tsx