Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another notification related translation fix #1716

Merged

Conversation

sashko9807
Copy link
Member

@sashko9807 sashko9807 commented Feb 1, 2024

Between the News and The campaign was supported by sections, inside CampaignDetails component.

Not every page includes the auth namespace, thus on some pages, translation on buttons is broken(Blog, finance report etc..)
Move notification related ctas, to the common namespace
Between the News and The campaign was supported by sections
@sashko9807 sashko9807 added the area: i18n Translation related issues label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@sashko9807 sashko9807 changed the title Hopefully last trans fix Another notification related translation fix Feb 1, 2024
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Feb 1, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Feb 1, 2024
@ani-kalpachka ani-kalpachka merged commit fbca1ba into podkrepi-bg:master Feb 2, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: i18n Translation related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants