components/commmon: Gallery component improvements #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sashko9807
commented
Jan 19, 2024
•
sashko9807
commented
- Improved logic to render the Gallery Component more efficiently
- Increased the size of the images, when Gallery full screen is toggled
- Added a button to minimize full screen slider
| Before | After |
|---|---|
 |
 |
- Improved logic to render the Gallery Component more efficiently - Expanded the size of the images, when FullScreen is toggled - Added a button to minimize fullscreen slider
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
|
Great. Can you add a couple of screenshots? |
In some situations, only a single image is uploaded, and in that case child.props.children is an object rather, than an array to map it over.
Done. Check PR message. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
Avoid minimizing gallery due to accidental touches
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
ani-kalpachka
approved these changes
Jan 20, 2024
slavcho
approved these changes
Jan 20, 2024
slavcho
pushed a commit
to slavcho/frontend
that referenced
this pull request
Jan 22, 2024
* components/commmon: Gallery component improvements - Improved logic to render the Gallery Component more efficiently - Expanded the size of the images, when FullScreen is toggled - Added a button to minimize fullscreen slider * common/Gallery: Fix component crash when child is a single image In some situations, only a single image is uploaded, and in that case child.props.children is an object rather, than an array to map it over. * common/ImageSlider: Hide backdrop on FullScreenImageSlider Avoid minimizing gallery due to accidental touches
slavcho
pushed a commit
to slavcho/frontend
that referenced
this pull request
Jan 22, 2024
* components/commmon: Gallery component improvements - Improved logic to render the Gallery Component more efficiently - Expanded the size of the images, when FullScreen is toggled - Added a button to minimize fullscreen slider * common/Gallery: Fix component crash when child is a single image In some situations, only a single image is uploaded, and in that case child.props.children is an object rather, than an array to map it over. * common/ImageSlider: Hide backdrop on FullScreenImageSlider Avoid minimizing gallery due to accidental touches
slavcho
added a commit
that referenced
this pull request
Jan 24, 2024
* Remove unused translations, add EN translations for bank transactions (#1703) * Remove unused import and translations * Remove unused translations, added EN translations for bank transactions * Remove unused translations from campaigns.json * Remove unused translations from campaign.json * Add missing EN trnlations in campaigns.json * Add missing translations for common.json * Fix lint error --------- Co-authored-by: ani-kalpachka <[email protected]> * Update email address on FAQ (#1705) Co-authored-by: ani-kalpachka <[email protected]> * Update translations (#1706) * Update translations * Update tranlations * Update translations --------- Co-authored-by: ani-kalpachka <[email protected]> * Update translations (#1707) * Add missing EN translations * Update translations for support.json and reccurong-donation.json * Update translations for validation.json and transfer.json * Update translations --------- Co-authored-by: ani-kalpachka <[email protected]> * components/commmon: Gallery component improvements (#1708) * components/commmon: Gallery component improvements - Improved logic to render the Gallery Component more efficiently - Expanded the size of the images, when FullScreen is toggled - Added a button to minimize fullscreen slider * common/Gallery: Fix component crash when child is a single image In some situations, only a single image is uploaded, and in that case child.props.children is an object rather, than an array to map it over. * common/ImageSlider: Hide backdrop on FullScreenImageSlider Avoid minimizing gallery due to accidental touches * The amount of the withdrawals can be a decimal number. It should not be limited to integers only. --------- Co-authored-by: Ani <[email protected]> Co-authored-by: ani-kalpachka <[email protected]> Co-authored-by: Aleksandar Petkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.