Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for campaign news subscription #1632

Closed

Conversation

RalitsaIlieva
Copy link
Contributor

Closes partially #1550 (campaign news subscription)

Motivation and context

There is new design that should be implemented

Screenshots:

image
image
image
image

Before After
Paste screenshot Paste screenshot

Testing

Steps to test

Affected urls

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
dependency/name v1.0.0 v2.0.0

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

❌ Not all tests have run for this PR. Please add the run tests label to trigger them.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Oct 27, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Oct 27, 2023
@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Oct 29, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Oct 29, 2023
@ani-kalpachka
Copy link
Member

@RalitsaIlieva well done!
Could you please check the conflicts?

@ani-kalpachka
Copy link
Member

Is the backend for this task fully completed?

@RalitsaIlieva
Copy link
Contributor Author

Is the backend for this task fully completed?

No, the backend should be checked. @igoychev is aware of this and promised to check

@slavcho
Copy link
Contributor

slavcho commented Jan 16, 2024

What else do we need to do here?

@ani-kalpachka
Copy link
Member

@RalitsaIlieva is this task completed from your perspective or you still need to do some work on it?

@RalitsaIlieva
Copy link
Contributor Author

@ani-kalpachka @slavcho nothing has to be done here. The things are merged with the PR about the news subscription. News subscription PR included this campaign news subscription because when I started the work for the news subscription I branched from this one.

@slavcho
Copy link
Contributor

slavcho commented Jan 17, 2024

Thanks @RalitsaIlieva . Can you suggest what else is needed to move this forward?

@sashko9807
Copy link
Member

Thanks @RalitsaIlieva . Can you suggest what else is needed to move this forward?

I believe this is just a duplicate PR of #1673, and can be closed.

@ani-kalpachka
Copy link
Member

Thanks! I will close this PR as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants