-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New design for campaign news subscription #1632
New design for campaign news subscription #1632
Conversation
❌ Not all tests have run for this PR. Please add the |
@RalitsaIlieva well done! |
Is the backend for this task fully completed? |
No, the backend should be checked. @igoychev is aware of this and promised to check |
What else do we need to do here? |
@RalitsaIlieva is this task completed from your perspective or you still need to do some work on it? |
@ani-kalpachka @slavcho nothing has to be done here. The things are merged with the PR about the news subscription. News subscription PR included this campaign news subscription because when I started the work for the news subscription I branched from this one. |
Thanks @RalitsaIlieva . Can you suggest what else is needed to move this forward? |
I believe this is just a duplicate PR of #1673, and can be closed. |
Thanks! I will close this PR as a duplicate. |
Closes partially #1550 (campaign news subscription)
Motivation and context
There is new design that should be implemented
Screenshots:
Testing
Steps to test
Affected urls
Environment
New environment variables:
NEW_ENV_VAR
: env var detailsNew or updated dependencies:
dependency/name
v1.0.0
v2.0.0