Target Date Field added to withdrawals forms. #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Field added in both createForm.tsx and editForm.tsx. -Added targetDate in gql/withdrawals.d.ts types. -Created SelectDate.tsx file for the custom element.
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
github-actions
bot
removed
the
run tests
Eddited targetDate in withdrawals.d.ts to required Eddited targetDate in transfer.d.ts to required Fixed validationSchema in ../withdrawals/CreateForm.tsx and EditForm.tsx - validation permits usage of previous date now Fixed validationSchema in ../transfers/CreateForm.tsx and EditForm.tsx - validation permits usage of previous date now
-minor issues fixed- forgotten save of EditForm.tsx
github-actions
bot
removed
the
run tests
|
Good update, hiapetrov ! |
looks like not needed for this branch
igoychev
approved these changes
Oct 3, 2023
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Field added in both createForm.tsx and editForm.tsx. -Added targetDate in gql/withdrawals.d.ts types.
-Created SelectDate.tsx file for the custom element.
Closes #1558 Withdrawal: New field
Motivation and context
Screenshots:
Testing
Steps to test
Affected urls
Environment
New environment variables:
NEW_ENV_VAR: env var detailsNew or updated dependencies:
dependency/namev1.0.0v2.0.0