-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform otherAmount select to input field #1581
Transform otherAmount select to input field #1581
Conversation
✅ Tests will run for this PR. Once they succeed it can be merged. |
@@ -18,6 +20,10 @@ export default function NumberInputField({ | |||
const [, meta, { setValue, setError }] = useField(name) | |||
const decimalSeparator = (1.1).toLocaleString(i18n.lang).charAt(1) | |||
|
|||
useEffect(() => { | |||
setValue(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm setting the value to 1, because currently there is brief moment where the validation gets triggered and the Минималната сума която може да дарите с карта е 1лв.
error message gets shown. This was kinda hidden by the Collapse
animation.
Great find! Let's add the missing one - please search for 'transaction-limit' in the code(Ctrl+Shift+F) and it will show you the translation files with translations and feel free to add the "only-numbers" text messages. |
I added the missing translation. Hope the text is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great change and very professional side improvements for the translations!
Closes #1561
Motivation and context
otherAmount
option, the input field renders in it's place instead of next to it, to avoid confusion for the usersScreenshots:
Before
After
Testing
Steps to test
Other Amount
field