hooks/campaigns.ts: Disable useCampaignList on client #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Campaigns' data is prefetched on the server, and since campaign's data is no longer stale, it results in 2 queries to the server being made. Due to the call of useCampaignList twice, the campaigns are being reordered twice - once on the server, once on client load, which makes it unpleasant for the users
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary data is prefetched on the server, and since campaign's data is no longer considered stale, it results in 2 queries to the server being made.
Due to the call of useCampaignList, the campaigns are being reordered twice - once on the server, once on client load, which makes it unpleasant for the users.