Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate mdxeditor #1546

Merged
merged 15 commits into from
Aug 24, 2023
Merged

Integrate mdxeditor #1546

merged 15 commits into from
Aug 24, 2023

Conversation

petyosi
Copy link
Contributor

@petyosi petyosi commented Aug 8, 2023

Adds mdxeditor as an option for the rich text editor in the campaigns.

Closes #1503.

Motivation and context

MDXEditor works with Markdown, which drives the following improvements:

  • Easier, editor-independent content storage
  • Content can be SSR, driving better SEO
  • Support for image paste, drag and drop
  • Future integration with tables
  • Preserve formatting when copy/paste from google docs

Screenshots:

image

Affects the campaigns administrative interface UI.

Testing

  • TODO

Steps to test

Affected urls

  • /admin/campaigns/edit/guid
  • TODO

Environment

New or updated dependencies:

  • MDXEditor (new)
  • Bumps TypeScript to v5. TS5 reads the exports field from package.json, which means that only the editor parts used by the site will be included in the bundle
  • Added some resolution rules, so that only one @types/react package is used (resolves errors with type-check)

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 21, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 21, 2023
@petyosi petyosi force-pushed the integrate-mdxeditor branch from eadd0fd to 1e31fd7 Compare August 22, 2023 07:52
@petyosi petyosi marked this pull request as ready for review August 22, 2023 07:56
@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 22, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 22, 2023
@petyosi
Copy link
Contributor Author

petyosi commented Aug 22, 2023

Note: PR is to be squashed into a single commit, no useful semantics to be preserved.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 22, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 22, 2023
@petyosi
Copy link
Contributor Author

petyosi commented Aug 24, 2023

@igoychev - updated the package to prevent dialogs from submitting the entire form, check it out.

Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have the brand new editor! Thank you for the contribution and the well thought backward compatibility!

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 24, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 24, 2023
@igoychev igoychev merged commit 523b8e9 into podkrepi-bg:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try MDXEditor for our RichTextEdit component
2 participants