Add UI updates on Campaign cards and Inline Donation component #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani-kalpachka
changed the title
sashko9807
reviewed
Jul 19, 2023
| @@ -38,6 +38,7 @@ | |||
| "@mui/x-date-pickers": "^6.5.0", | |||
| "@next/font": "^13.0.5", | |||
| "@paypal/react-paypal-js": "^7.8.1", | |||
| "@ramonak/react-progress-bar": "^5.0.3", | |||
There was a problem hiding this comment.
Why is a new progress bar package needed?
There was a problem hiding this comment.
@sashko9807
I was not able to achieve this effect:
with the Progress bar provided from MUI (https://mui.com/material-ui/react-progress/).
Probably there is a way to do it but it would overcomplicate the logic.
If you think we should avoid the library, please share alternative ideas.
There was a problem hiding this comment.
I had the same question but, now that we have the answer - all good. Later we can remove it if we find a way to do it without separate library.
igoychev
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the whole campaign card a link (currently on prod only the image is a link to campaign details).
Added hover effect on the card.
Aligned Donate button.
Add space above active campaigns.
Updated campaign cards' spacings.
Fixed console error caused by button tag inside a button tag:
Removed unnecessary white space above campaigns title:
Separated money unit from money fraction in InlineDonation component:
TODO: Add "лв' currency for BG locale.
The changes are discussed with the design team.