notificationClient: Establish ws connection only on client render

[sashko9807]

Closes #1454

Motivation and context

The current websocket configuration, creates a new websocket client, for every SSR generated page. Since those clients are technically active, they are never cleaned up, thus resulting in memory leak. This change makes it so, a new web socket connection is created only on first render of the component.

Testing

Steps to test

1. Start visiting different pages randomly
2. Observe the current websocket clients, in the Socket object (you can console.log the client arg from handleConnection) . The total amount of active clients can be found in Socket.adapters.sids
3. The size of sids should remain 1, per browser window

[github-actions]

✅ Tests will run for this PR. Once they succeed it can be merged.

[slavcho]

I thought there was no problem here, but I was wrong...
It reproduces when you start clicking on multiple pages.

This actually fixes the issue #1454. I've tested it.

[imilchev]

can we also make sure that connections are kept open only if you have the window focused? This means unless podkrepi.bg is opened in a non-minimized browser window, there should be no socket connection open.

You can check this. What I am suggesting is to open and close socket connections based on the visibilityState. I am fine with doing that in a follow-up PR too

[sashko9807]

can we also make sure that connections are kept open only if you have the window focused? This means unless podkrepi.bg is opened in a non-minimized browser window, there should be no socket connection open.

You can check this. What I am suggesting is to open and close socket connections based on the visibilityState. I am fine with doing that in a follow-up PR too

Done I think.
Should temporary switched off donation notification popups be reverted in this PR, or this will be handled in another one?

[imilchev]

Let's flip the switch in another PR

[imilchev]

Great work on this! This should help a lot with the resource usage for those websockets 🚀

[igoychev]

great work for protecting from excessive connections!!!