Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en/one-time-donation.js: Swap the places of {{totalAmount}} and {{amount}} #1331

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

sashko9807
Copy link
Member

Closes #1244

Screenshots:

Before After
image image

Testing

Steps to test

  1. Switch the language

Affected urls

{{local}}/campaigns/donation/{{slug}}

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, however as per the screenshot, it looks like the actual problem is in the English translation. So instead of changing the BG text, the fix should be in the English text where totalAmount and amount fields need to become the same like in the BG text.

src/components/one-time-donation/steps/FirstStep.tsx Outdated Show resolved Hide resolved
@sashko9807 sashko9807 force-pushed the master branch 2 times, most recently from 8489eb4 to fb8bdf7 Compare February 10, 2023 14:36
@sashko9807 sashko9807 changed the title steps/FirstStep.tsx: Fix incorrect value assigment to 'amountWithFees'and 'amountWithoutFees' fields en/one-time-donation.js: Swap the places of {{totalAmount}} and {{amount}} Feb 10, 2023
@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Feb 14, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Feb 14, 2023
@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Feb 14, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Feb 14, 2023
@igoychev igoychev merged commit b6ee45a into podkrepi-bg:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Donation and total amount texts arrangement is different for BG and EN languages in Donation page
2 participants