Fix - e2e checkURL tests failing unexpectedly
#1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitur2204
added
type: bug
dimitur2204
changed the title
umountOnExit on donation form collapsescheckURL tests failing unexpectedly
dimitur2204
requested review from
ani-kalpachka,
DanielTakev,
igoychev and
kachar
…cause of emails, add --immutable to `yarn install`s
kachar
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
There seems to be some issues with e2e tests failing, because of
checkURLproblems.I also ran into problems locally, where the
<Collapse>MUI animation would not unmount a component on exit and there were cases where playwright was trying to access elements that were hidden.For the installation of the dependencies seems like without running
yarn install --immutablethere are resolutions errors sometimes.Found some people also having the same problem and seems like having --immutable in CI actions is a better approach
redwoodjs/redwood#4822 (comment)