Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Donation Flow - Stripe elements components for getting the users payment details #1269

Conversation

dimitur2204
Copy link
Contributor

@dimitur2204 dimitur2204 commented Dec 29, 2022

Closes #1267

Related to API podkrepi-bg/api#410

Motivation and context

We will need this element in the new donation flow, so I created and styled the Stripe Payments Element to be styled as the our inputs currently look.

Screenshots:

image

Testing

You can go on the donation page, uncomment the commented code and check it out. You would also need the STRIPE_PUBLIC_KEY

Affected urls

No affected urls since it's not used currently.

Environment

New environment variables:

  • STRIPE_PUBLIC_KEY: The public key for Stripe.

New or updated dependencies:

Dependency name Previous version Updated version Details
@stripe/react-stripe-js v^1.16.1
@stripe/stripe-js ^1.46.0

@dimitur2204 dimitur2204 self-assigned this Dec 29, 2022
@dimitur2204 dimitur2204 changed the title 1267 implement the stripe elements components for getting the users payment details in our app Stripe elements components for getting the users payment details Dec 29, 2022
@dimitur2204 dimitur2204 requested a review from kachar December 29, 2022 11:57
@dimitur2204 dimitur2204 marked this pull request as ready for review December 29, 2022 12:36
Copy link
Member

@kachar kachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimitur2204 woow, cool integration, it's such a step stone towards the next iteration of the donation flow epic.

As I see this process doesn't interfere with the current donation flow so I'm happy to have it on board.

Related to podkrepi-bg/api#410

@dimitur2204 dimitur2204 merged commit a470159 into master Dec 30, 2022
@dimitur2204 dimitur2204 deleted the 1267-implement-the-stripe-elements-components-for-getting-the-users-payment-details-in-our-app branch December 30, 2022 15:33
@dimitur2204 dimitur2204 mentioned this pull request Jan 4, 2023
13 tasks
@dimitur2204 dimitur2204 changed the title Stripe elements components for getting the users payment details New Donation Flow - Stripe elements components for getting the users payment details Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Stripe Elements components for getting the user's payment details in our app
2 participants